feat: support custom report dataformat like Taskwarrior #636
Conversation
|
@kdheepak Sorry, should have tagged you on this draft. |
|
I think this is great! Thanks for implementing a draft, I'd be open to adding this feature. My first thought is I'm not sure if all taskwarrior dateformats can be converted to chrono. If we can get a fallback for when that happens that would be good enough I think. |
|
Thank you! I'll work on polishing it up and mark it when it's ready. I have a few other improvements I could work on and thought this would be a good one to get familiar with the project. Big fan! |
jakebox
force-pushed
the
jb/dateformat-support
branch
from
e77ef8c to
aa1f493
Compare
|
Okay, this should be ready! All of the taskwarrior date formats (https://taskwarrior.org/docs/dates/) are mapped to chrono (https://docs.rs/chrono/latest/chrono/format/strftime/index.html) formats, and any other characters just get passed through raw. If no format is provided we fallback to the existing |
|
These errors are from a file I haven't touched. Want me to fix them in this PR or another one? |
|
If you can fix this in this PR that would be awesome! But no worries, I can also look at them later. |
|
Fixed! I was on cargo |
|
Just want to check over a few more things. |
|
Hi @kdheepak can we merge? Thanks! |
|
Awesome, thank you!! This was fun and I hope to make some more contributions soon enough. Also, calling out that your deployment seems to not be working so new versions are not build on GitHub. |
|
jfyi, I haven't forgotten about this, my plan is to update |
|
Never mind, made a release (accidentally)! |
|
Nice! Let me know if you need any support on anything. I'm enjoying taskwarrior-tui and have a little energy/time to help if needed. |
|
Awesome! Thank you for the offer! :) Reporting any bugs you find would be amazing by itself. I have had a lot less time to devote to this than I would like, but have been meaning to get back to it again. So any small PRs like this would be great too, but absolutely no pressure. |
2 participants
Thanks for all the hard work on taskwarrior-tui!
I thought it would be nice if tw-tui supported taskwarrior's
report._.dateformatoption. This PR reads this configuration parameter and uses it when formatting theduetask property.The only slight complexity in implementation is converting from Taskwarrior's date formatting to
chronodate format. I want to spend a little more time cleaning this up, but wanted to post this draft PR to see if this is an acceptable feature to add.-jacob